linux-kernel - Re: [PATCH v2] iio: pressure: bmp280: Use IS_ERR() in bmp280_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f34219ae-098f-4732-94e9-f077316d843d@web.de>
Date: Sun, 10 Aug 2025 10:08:52 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Salah Triki <salah.triki@...il.com>, linux-iio@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy@...nel.org>,
 David Lechner <dlechner@...libre.com>, Jonathan Cameron <jic23@...nel.org>,
 Nuno Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v2] iio: pressure: bmp280: Use IS_ERR() in
 bmp280_common_probe()

> `devm_gpiod_get_optional()` may return non-NULL error pointer on failure.
> Check its return value using `IS_ERR()` and propagate the error if
> necessary.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n145

> Also switch to `gpiod_set_value_cansleep()`, which is safe to use in
> sleepable contexts like probe.

Would it be helpful to provide desirable changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n81

Regards,
Markus