linux-kernel - Re: [PATCH] serial: max310x: Add error checking in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcVA+yARTBvcOiKYdhgxtS_YQ82Xd-R4o98OTGp167ZQw@mail.gmail.com>
Date: Thu, 7 Aug 2025 23:30:34 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Cosmin Tanislav <cosmin.tanislav@...log.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] serial: max310x: Add error checking in probe()

On Thu, Aug 7, 2025 at 5:54 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> Check if devm_i2c_new_dummy_device() fails.

...

>                 port_client = devm_i2c_new_dummy_device(&client->dev,
>                                                         client->adapter,
>                                                         port_addr);
> +               if (IS_ERR(port_client))
> +                       return PTR_ERR(port_client);

I'm wondering if this is indeed a critical error in this case, but okay.

-- 
With Best Regards,
Andy Shevchenko