linux-kernel - Re: [PATCH v6 1/4] dt-bindings: clock: ipq5424-apss-clk: Add ipq5424 apss clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJQtyouomCxI8Rfa@hu-varada-blr.qualcomm.com>
Date: Thu, 7 Aug 2025 10:08:34 +0530
From: Varadarajan Narayanan <quic_varada@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <konradybcio@...nel.org>, <rafael@...nel.org>,
        <viresh.kumar@...aro.org>, <ilia.lin@...nel.org>, <djakov@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>,
        "Sricharan
 Ramabadhran" <quic_srichara@...cinc.com>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>,
        Md Sadre Alam <quic_mdalam@...cinc.com>
Subject: Re: [PATCH v6 1/4] dt-bindings: clock: ipq5424-apss-clk: Add ipq5424
 apss clock controller

On Wed, Aug 06, 2025 at 01:47:34PM +0200, Krzysztof Kozlowski wrote:
> On 06/08/2025 13:28, Varadarajan Narayanan wrote:
> > From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
> >
> > The CPU core in ipq5424 is clocked by a huayra PLL with RCG support.
> > The RCG and PLL have a separate register space from the GCC.
> > Also the L3 cache has a separate pll and needs to be scaled along
> > with the CPU.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> This is oddly placed. Did you use b4 that it appeared here?

b4 places like this

	Co-developed-by: Md Sadre Alam <quic_mdalam@...cinc.com>
	Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
	Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
	[ Added interconnect related changes ]
	Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
	Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Since I haven't seen Reviewed-by coming after Signed-off-by, Was not
sure if my Signed-off-by should come before or after the Reviewed-by.
So, manually placed it there. If this is not ok, will use how b4's
placement itself and post the next version. Kindly, let me know.

Thanks
Varada

> > Co-developed-by: Md Sadre Alam <quic_mdalam@...cinc.com>
> > Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
> > [ Added interconnect related changes ]
> > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > ---
> > v6: Add 'Reviewed-by: Krzysztof Kozlowski'
> >     Drop 'clock-names'
>
> Best regards,
> Krzysztof