linux-kernel - Re: [PATCH -next] um: Use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69f40a6f907deb7225cb6c1c8f59926d98a580b2.camel@sipsolutions.net>
Date: Thu, 07 Aug 2025 07:08:58 +0200
From: Benjamin Berg <benjamin@...solutions.net>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, richard@....at
Cc: anton.ivanov@...bridgegreys.com, johannes@...solutions.net, 
	linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org, Abaci Robot
	 <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] um: Use ARRAY_SIZE for array length

Hi,

there is a good reason for this. The bug is a false positive as the
relevant include is not (and cannot be) used in the file. This patch
does not even compile.

Benjamin

On Thu, 2025-08-07 at 10:32 +0800, Jiapeng Chong wrote:
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> 
> ./arch/um/kernel/skas/stub_exe.c:196:23-24: WARNING: Use ARRAY_SIZE.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=23410
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  arch/um/kernel/skas/stub_exe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/skas/stub_exe.c
> b/arch/um/kernel/skas/stub_exe.c
> index cbafaa684e66..01a938a5bb4f 100644
> --- a/arch/um/kernel/skas/stub_exe.c
> +++ b/arch/um/kernel/skas/stub_exe.c
> @@ -193,7 +193,7 @@ noinline static void real_init(void)
>  			BPF_STMT(BPF_RET | BPF_K,
> SECCOMP_RET_ALLOW),
>  		};
>  		struct sock_fprog prog = {
> -			.len = sizeof(filter) / sizeof(filter[0]),
> +			.len = ARRAY_SIZE(filter),
>  			.filter = filter,
>  		};
>