[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <24439698-ac81-43b5-b808-e912954f573f@portwell.com.tw>
Date: Thu, 7 Aug 2025 17:45:16 +0800
From: Yen-Chi Huang <jesse.huang@...twell.com.tw>
To: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, jdelvare@...e.com,
linux@...ck-us.net, wim@...ux-watchdog.org
Cc: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-watchdog@...r.kernel.org,
jay.chen@...onical.com
Subject: Re: [PATCH v3 0/2] platform/x86: portwell-ec: Add watchdog
suspend/resume and hwmon
Hi Ilpo, Guenter,
Gentle ping on this patch series.
If patch 2/2 (hwmon) still requires further work,
would it be possible to apply patch 1/2 (watchdog suspend/resume support)
independently?
For completeness: I kept the `(void *)` cast in `.driver_data` because
`pwec_board_data_nano` is `const`. As discussed in v2, removing it triggers
a compiler warning about discarding the qualifier.
Thanks again for your time and feedback.
Best regards,
Yen-Chi Huang
On 7/28/2025 7:56 PM, Yen-Chi Huang wrote:
> This patch series adds suspend/resume support for the watchdog (patch 1/2)
> and hwmon monitoring functionality (patch 2/2) to the Portwell EC driver.
> These changes enable better power management and sensor reporting.
>
> Tested on Portwell NANO-6064.
> ---
> V2->V3:
>
> Patch 1/2:
> - Unchanged
>
> Patch 2/2:
> - Replace hardcoded `1000` with `MILLIDEGREE_PER_DEGREE` and double check
> - Fix comma placement and spacing coding style issues
> - Simplify pwec_hwmon_is_visible() with ternary operator
>
> V1->V2:
>
> - Added watchdog mailing list to Cc.
>
> Patch 1/2:
> - unchanged
>
> Patch 2/2:
> - Removed `msb_reg` from `strucit pwec_hwmon_data`
> - Updated `pwec_read16_stable()` to assume MSB follows LSB
> - Moved `hwmon_channel_info` to per-board data and assigned it to `.info` at runtime
> - Replaced the `pwec_board_data[]` array with a standalone struct
> - Replaced literal `1000` with `MILLIDEGREE_PER_DEGREE`
> - Removed unused include and sorted header includes
>
> ---
> Yen-Chi Huang (2):
> platform/x86: portwell-ec: Add suspend/resume support for watchdog
> platform/x86: portwell-ec: Add hwmon support for voltage and temperature
>
> drivers/platform/x86/portwell-ec.c | 193 ++++++++++++++++++++++++++++-
> 1 file changed, 191 insertions(+), 2 deletions(-)
>
Powered by blists - more mailing lists