linux-kernel - Re: [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume support for watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6584da3e-fc86-7a47-f783-da77049b2215@linux.intel.com>
Date: Tue, 19 Aug 2025 12:51:39 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Yen-Chi Huang <jesse.huang@...twell.com.tw>
cc: Hans de Goede <hdegoede@...hat.com>, jdelvare@...e.com, linux@...ck-us.net, 
    wim@...ux-watchdog.org, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, linux-hwmon@...r.kernel.org, 
    linux-watchdog@...r.kernel.org, jay.chen@...onical.com
Subject: Re: [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume
 support for watchdog

On Mon, 28 Jul 2025, Yen-Chi Huang wrote:

> Portwell EC does not disable the watchdog during suspend. To avoid unwanted
> resets, this patch adds suspend and resume callbacks (pwec_suspend() and
> pwec_resume()) to the driver.
> 
> The watchdog is stopped in pwec_suspend() and restarted in pwec_resume() if
> it was active before suspend.
> 
> Signed-off-by: Yen-Chi Huang <jesse.huang@...twell.com.tw>
> ---
>  drivers/platform/x86/portwell-ec.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
> index 3e019c51913e..7f473e3032e2 100644
> --- a/drivers/platform/x86/portwell-ec.c
> +++ b/drivers/platform/x86/portwell-ec.c
> @@ -246,11 +246,29 @@ static int pwec_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static int pwec_suspend(struct platform_device *pdev, pm_message_t message)
> +{
> +	if (watchdog_active(&ec_wdt_dev))
> +		return pwec_wdt_stop(&ec_wdt_dev);
> +
> +	return 0;
> +}
> +
> +static int pwec_resume(struct platform_device *pdev)
> +{
> +	if (watchdog_active(&ec_wdt_dev))
> +		return pwec_wdt_start(&ec_wdt_dev);
> +
> +	return 0;
> +}
> +
>  static struct platform_driver pwec_driver = {
>  	.driver = {
>  		.name = "portwell-ec",
>  	},
>  	.probe = pwec_probe,
> +	.suspend = pm_ptr(pwec_suspend),
> +	.resume = pm_ptr(pwec_resume),

These are legacy handlers, please use .pm under .driver and the macros to 
create the struct dev_pm_ops.

-- 
 i.