linux-kernel - Re: [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume support for watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f72da7c2-cd2f-4b09-8cc5-7b08ad54dde8@portwell.com.tw>
Date: Tue, 26 Aug 2025 17:43:29 +0800
From: Yen-Chi Huang <jesse.huang@...twell.com.tw>
To: ilpo.jarvinen@...ux.intel.com
Cc: hdegoede@...hat.com, jdelvare@...e.com, linux@...ck-us.net,
 wim@...ux-watchdog.org, linux-kernel@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-watchdog@...r.kernel.org, jay.chen@...onical.com
Subject: Re: [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume
 support for watchdog

On 8/19/2025 5:51 PM, Ilpo Jarvinen wrote:
> On Mon, 28 Jul 2025, Yen-Chi Huang wrote:
>>  static struct platform_driver pwec_driver = {
>>  	.driver = {
>>  		.name = "portwell-ec",
>>  	},
>>  	.probe = pwec_probe,
>> +	.suspend = pm_ptr(pwec_suspend),
>> +	.resume = pm_ptr(pwec_resume),
> 
> These are legacy handlers, please use .pm under .driver and the macros to 
> create the struct dev_pm_ops.
> 

Hi Ilpo,

Thanks for pointing this out. For v4, I have switched to .pm with
DEFINE_SIMPLE_DEV_PM_OPS as suggested.

Best regards,
Yen-Chi