linux-kernel - Re: [PATCH v4 2/3] powerpc/eeh: Use result of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e27675effcee26fce059a7e81ea4ba0fecfa86d.camel@linux.ibm.com>
Date: Thu, 07 Aug 2025 13:49:26 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Lukas Wunner <lukas@...ner.de>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
        Mahesh J Salgaonkar	
 <mahesh@...ux.ibm.com>,
        Linas Vepstas <linasvepstas@...il.com>,
        Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Manivannan
 Sadhasivam <mani@...nel.org>,
        Gerald Schaefer	
 <gerald.schaefer@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger	 <borntraeger@...ux.ibm.com>,
        Sven Schnelle
 <svens@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Matthew
 Rosato <mjrosato@...ux.ibm.com>,
        "Oliver O'Halloran"	 <oohall@...il.com>, Sinan Kaya <okaya@...nel.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        Keith Busch	 <kbusch@...nel.org>
Subject: Re: [PATCH v4 2/3] powerpc/eeh: Use result of error_detected() in
 uevent

On Thu, 2025-08-07 at 13:34 +0200, Lukas Wunner wrote:
> On Thu, Aug 07, 2025 at 12:15:32PM +0200, Niklas Schnelle wrote:
> > With pci_uevent_ers() handling PCI_ERS_RESULT_NEED_RESET the result of
> > error_detected() can be used in pci_uevent_ers() even if drivers request
> > a reset. This aligns EEH's behavior with both AER.
> 
> I guess the sentence is supposed to end with "and s390"?

Yes had it there and then realized that this is only true after the
last patch, did a bad job of adjusting.

> 
> I would have recounted the history a bit, e.g.:
> 
> Ever since uevent support was added for AER and EEH with commit
> 856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it
> reported PCI_ERS_RESULT_NONE as the result of ->error_detected() to
> user space.
> 
> Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for
> udev") subsequently amended AER to report the actual return value of
> ->error_detected().
> 
> Make the same change to EEH to align it with AER (and s390 error
> recovery).

Thanks for figuring out the history, I'll incorporate this and send a
v5.

> 
> > Suggested-by: Lukas Wunner <lukas@...ner.de>
> > Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/
> > Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> 
> Reviewed-by: Lukas Wunner <lukas@...ner.de>

Thanks for the R-b.