linux-kernel - Re: [PATCH 1/3] dt-bindings: input: Add bindings for Awinic AW86927

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250807000801.GA2081012-robh@kernel.org>
Date: Wed, 6 Aug 2025 19:08:01 -0500
From: Rob Herring <robh@...nel.org>
To: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Luca Weiss <luca.weiss@...rphone.com>, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: input: Add bindings for Awinic AW86927

On Wed, Aug 06, 2025 at 05:10:08PM +0200, Griffin Kroah-Hartman wrote:
> Add bindings for the Awinic AW86927 haptic chip which can be found in
> smartphones.
> 
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
> ---
>  .../devicetree/bindings/input/awinic,aw86927.yaml  | 48 ++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/awinic,aw86927.yaml b/Documentation/devicetree/bindings/input/awinic,aw86927.yaml
> new file mode 100644
> index 000000000000..43012f28d9aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/awinic,aw86927.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only)

Dual license please: OR BSD-2-Clause

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/awinic,aw86927.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW86927 LRA Haptics driver

The binding is for a device, not a driver. So drop 'driver'.

Otherwise, looks good.

> +
> +maintainers:
> +  - Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
> +
> +properties:
> +  compatible:
> +    const: awinic,aw86927
> +
> +  reg:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        vibrator@5a {
> +            compatible = "awinic,aw86927";
> +            reg = <0x5a>;
> +            interrupts-extended = <&tlmm 101 IRQ_TYPE_EDGE_FALLING>;
> +            reset-gpios = <&tlmm 100 GPIO_ACTIVE_LOW>;
> +        };
> +    };
> 
> -- 
> 2.43.0
>