linux-kernel - Re: [RFC 2/4] net/tls/tls_sw: use the record size limit specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa5680f2974cb18e4a7d40266a85727ef43377c4.camel@gmail.com>
Date: Thu, 07 Aug 2025 10:04:30 +1000
From: Wilfred Mallawa <wilfred.opensource@...il.com>
To: Damien Le Moal <dlemoal@...nel.org>, alistair.francis@....com, 
	chuck.lever@...cle.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, 	pabeni@...hat.com, horms@...nel.org,
 donald.hunter@...il.com, corbet@....net, 	kbusch@...nel.org,
 axboe@...nel.dk, hch@....de, sagi@...mberg.me, kch@...dia.com, 
	borisp@...dia.com, john.fastabend@...il.com, jlayton@...nel.org,
 neil@...wn.name, 	okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com,
 trondmy@...nel.org, 	anna@...nel.org, kernel-tls-handshake@...ts.linux.dev,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-nvme@...ts.infradead.org, linux-nfs@...r.kernel.org
Subject: Re: [RFC 2/4] net/tls/tls_sw: use the record size limit specified

On Tue, 2025-07-29 at 17:13 +0900, Damien Le Moal wrote:
> On 7/29/25 11:41, Wilfred Mallawa wrote:
> > From: Wilfred Mallawa <wilfred.mallawa@....com>
> > 
> > Currently, for tls_sw, the kernel uses the default 16K
> > TLS_MAX_PAYLOAD_SIZE for records. However, if an endpoint has
> > specified
> > a record size much lower than that, it is currently not respected.
> 
> Remove "much". Lower is lower and we have to respect it, even if it
> is 1B.
> 
> > This patch adds support to using the record size limit specified by
> > an
> > endpoint if it has been set.
> 
> s/to using/for using
> 
> > 
> > Signed-off-by: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> > @@ -1045,6 +1046,13 @@ static int tls_sw_sendmsg_locked(struct sock
> > *sk, struct msghdr *msg,
> >  		}
> >  	}
> >  
> > +	if (tls_ctx->tls_record_size_limit > 0) {
> > +		tls_record_size_limit = min(tls_ctx-
> > >tls_record_size_limit,
> > +					    TLS_MAX_PAYLOAD_SIZE);
> > +	} else {
> > +		tls_record_size_limit = TLS_MAX_PAYLOAD_SIZE;
> > +	}
> 
> You can simplify this with:
> 
> 	tls_record_size_limit =
> 		min_not_zero(tls_ctx->tls_record_size_limit,
> 			     TLS_MAX_PAYLOAD_SIZE);
> 
Hey Damien,

Thanks for the feedback! Will amend for V2.

Regards,
Wilfred
> 
>