linux-kernel - Re: [RFC 1/4] net/handshake: get negotiated tls record size limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad14410ef291af926e7185d5d95cb0c932135ee3.camel@gmail.com>
Date: Thu, 07 Aug 2025 10:03:14 +1000
From: Wilfred Mallawa <wilfred.opensource@...il.com>
To: Hannes Reinecke <hare@...e.de>, alistair.francis@....com, 
	dlemoal@...nel.org, chuck.lever@...cle.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	donald.hunter@...il.com, corbet@....net, kbusch@...nel.org,
 axboe@...nel.dk, 	hch@....de, sagi@...mberg.me, kch@...dia.com,
 borisp@...dia.com, 	john.fastabend@...il.com, jlayton@...nel.org,
 neil@...wn.name, okorniev@...hat.com, 	Dai.Ngo@...cle.com, tom@...pey.com,
 trondmy@...nel.org, anna@...nel.org, 	kernel-tls-handshake@...ts.linux.dev,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-nvme@...ts.infradead.org, linux-nfs@...r.kernel.org
Subject: Re: [RFC 1/4] net/handshake: get negotiated tls record size limit

On Tue, 2025-07-29 at 10:12 +0200, Hannes Reinecke wrote:
> 
[snip]...
> > diff --git a/Documentation/networking/tls-handshake.rst
> > b/Documentation/networking/tls-handshake.rst
> > index 6f5ea1646a47..cd984a137779 100644
> > --- a/Documentation/networking/tls-handshake.rst
> > +++ b/Documentation/networking/tls-handshake.rst
> > @@ -169,7 +169,8 @@ The synopsis of this function is:
> >   .. code-block:: c
> >   
> >     typedef void	(*tls_done_func_t)(void *data, int status,
> > -                                   key_serial_t peerid);
> > +                                   key_serial_t peerid,
> > +                                   size_t tls_record_size_limit);
> >   
> >   The consumer provides a cookie in the @ta_data field of the
> >   tls_handshake_args structure that is returned in the @data
> > parameter of
> 
> Why is this exposed to the TLS handshake consumer?
> The TLS record size is surely required for handling and processing
> TLS
> streams in net/tls, but the consumer of that (eg NVMe-TCP, NFS)
> are blissfully unaware that there _are_ such things like TLS records.
> And they really should keep it that way.
> 
> So I'd really _not_ expose that to any ULP and keep it internal to
> the TLS layer.
> 
Hey Hannes,

Sorry for the delay in response, and thanks for the feedback! Yeah I
agree it was a bad approach from me. It definitely makes more sense to
keep things in the TLS layer. I will try to address this in V2.

Regards,
Wilfred