linux-kernel - Re: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f1a35fc-7fda-4179-948e-1a2acafd0f8a@kernel.org>
Date: Fri, 8 Aug 2025 08:11:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhu Yixin <yzhu@...linear.com>, vkoul@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, p.zabel@...gutronix.de,
 kees@...nel.org, dave.jiang@...el.com, av2082000@...il.com,
 dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management
 functions on HDMA.

On 08/08/2025 05:22, Zhu Yixin wrote:
> +
> +struct dw4_desc_sw {
> +	struct virt_dma_desc	vd;
> +	struct ldma_chan	*chan;
> +	struct dw4_desc_hw	*desc_hw;
> +};
> +
> +/**
> + * hdma TX need some sideband info to switch in dw0 and dw1

That's not a kerneldoc.

Please run standard kernel tools for static analysis, like coccinelle,
smatch and sparse, and fix reported warnings. Also please check for
warnings when building with W=1. Most of these commands (checks or W=1
build) can build specific targets, like some directory, to narrow the
scope to only your code. The code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.

Best regards,
Krzysztof