linux-kernel - RE: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR19MB4909614FC967757377DE7488C234A@SA1PR19MB4909.namprd19.prod.outlook.com>
Date: Fri, 15 Aug 2025 06:51:34 +0000
From: Yi xin Zhu <yzhu@...linear.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "vkoul@...nel.org"
	<vkoul@...nel.org>, "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "kees@...nel.org"
	<kees@...nel.org>, "dave.jiang@...el.com" <dave.jiang@...el.com>,
	"av2082000@...il.com" <av2082000@...il.com>, "dmaengine@...r.kernel.org"
	<dmaengine@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management
 functions on HDMA.

Hi Krzysztof,

On 08/08/2025 14:11, Krzysztof wrote:
> 
> > +/**
> > + * hdma TX need some sideband info to switch in dw0 and dw1
> 
> That's not a kerneldoc.

I will change it to /* */ format in the next patch submit.

> 
> Please run standard kernel tools for static analysis, like coccinelle, 
> smatch and sparse, and fix reported warnings. Also please check for 
> warnings when building with W=1. Most of these commands (checks or W=1
> build) can build specific targets, like some directory, to narrow the 
> scope to only your code. The code here looks like it needs a fix. Feel 
> free to get in touch if the warning is not clear.
> 
> 
> Best regards,
> Krzysztof

Thanks for reminding me to run these checks.
-W1 gave me warning on lgm-hdma.c.  I'll fix it in the next patch submit.
Coccinelle, smatch and sparse didn't report any meaningful warning.

make CROSS_COMPILE=x86_64-buildroot-linux-musl- CHECK="sparse" C=1 drivers/dma/lgm/
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC      drivers/dma/lgm/lgm-dma.o
  CHECK   drivers/dma/lgm/lgm-dma.c
  CC      drivers/dma/lgm/lgm-cdma.o
  CHECK   drivers/dma/lgm/lgm-cdma.c
  CC      drivers/dma/lgm/lgm-hdma.o
  CHECK   drivers/dma/lgm/lgm-hdma.c
  AR      drivers/dma/lgm/built-in.a

make CROSS_COMPILE=x86_64-buildroot-linux-musl- CHECK="smatch -p=kernel" C=1 drivers/dma/lgm/
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC      drivers/dma/lgm/lgm-dma.o
  CHECK   drivers/dma/lgm/lgm-dma.c
  CC      drivers/dma/lgm/lgm-cdma.o
  CHECK   drivers/dma/lgm/lgm-cdma.c
  CC      drivers/dma/lgm/lgm-hdma.o
  CHECK   drivers/dma/lgm/lgm-hdma.c
  AR      drivers/dma/lgm/built-in.a

Coccinelle give me some warnings, but I feel it is not my code related.
make CROSS_COMPILE=x86_64-buildroot-linux-musl- CHECK="scripts/coccicheck" C=1 drivers/dma/lgm/
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC      drivers/dma/lgm/lgm-dma.o
  CHECK   drivers/dma/lgm/lgm-dma.c
...
warning: line 140: should noop_llseek be a metavariable?
warning: line 222: should nonseekable_open be a metavariable?
warning: line 289: should nonseekable_open be a metavariable?
warning: line 337: should nonseekable_open be a metavariable?

Please let me know if the command or parameter is not properly set.

Best regards,
Yixin