linux-kernel - [PATCH] gpio: virtuser: remove debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aJd2Zho5QRUTAEzm@bhairav-test.ee.iitb.ac.in>
Date: Sat, 9 Aug 2025 21:55:10 +0530
From: Akhilesh Patil <akhilesh@...iitb.ac.in>
To: linus.walleij@...aro.org, brgl@...ev.pl, dianders@...omium.org
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	akhileshpatilvnit@...il.com, skhan@...uxfoundation.org
Subject: [PATCH] gpio: virtuser: remove debugfs_create_dir() error checks

Remove return value checks for debugfs_create_dir() wherever
appropriate. Follow guidelines mentioned in [1] that callers
should ignore errors returned as other debugfs functions handle them
appropriately.
Refer commit 8bcbde2bb1374 ("debugfs: Document that debugfs_create
functions need not be error checked") to clean up unnecessary error checks
without impacting the functionality.

Fixes: 91581c4b3f29e ("gpio: virtuser: new virtual testing driver for the GPIO API")
Link: https://lore.kernel.org/all/20220222154555.1.I26d364db7a007f8995e8f0dac978673bc8e9f5e2@changeid/ [1]
Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
---
 drivers/gpio/gpio-virtuser.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpio/gpio-virtuser.c b/drivers/gpio/gpio-virtuser.c
index a10eab7d2617..295b8718f39d 100644
--- a/drivers/gpio/gpio-virtuser.c
+++ b/drivers/gpio/gpio-virtuser.c
@@ -788,8 +788,6 @@ static int gpio_virtuser_dbgfs_init_line_array_attrs(struct device *dev,
 		return -ENOMEM;
 
 	data->ad.dbgfs_dir = debugfs_create_dir(name, dbgfs_entry);
-	if (IS_ERR(data->ad.dbgfs_dir))
-		return PTR_ERR(data->ad.dbgfs_dir);
 
 	return gpio_virtuser_create_debugfs_attrs(
 			gpio_virtuser_line_array_dbgfs_attrs,
@@ -825,8 +823,6 @@ static int gpio_virtuser_dbgfs_init_line_attrs(struct device *dev,
 		return ret;
 
 	data->ad.dbgfs_dir = debugfs_create_dir(name, dbgfs_entry);
-	if (IS_ERR(data->ad.dbgfs_dir))
-		return PTR_ERR(data->ad.dbgfs_dir);
 
 	return gpio_virtuser_create_debugfs_attrs(
 				gpio_virtuser_line_dbgfs_attrs,
-- 
2.34.1