linux-kernel - Re: [PATCH] gpio: virtuser: remove debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MczvR7w28Zw6Yn51W7wrkSHjitE3pimHBMgbL_zS8wYhQ@mail.gmail.com>
Date: Mon, 11 Aug 2025 09:47:13 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Akhilesh Patil <akhilesh@...iitb.ac.in>
Cc: linus.walleij@...aro.org, dianders@...omium.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	akhileshpatilvnit@...il.com, skhan@...uxfoundation.org
Subject: Re: [PATCH] gpio: virtuser: remove debugfs_create_dir() error checks

On Sat, Aug 9, 2025 at 6:25 PM Akhilesh Patil <akhilesh@...iitb.ac.in> wrote:
>
> Remove return value checks for debugfs_create_dir() wherever
> appropriate. Follow guidelines mentioned in [1] that callers
> should ignore errors returned as other debugfs functions handle them
> appropriately.
> Refer commit 8bcbde2bb1374 ("debugfs: Document that debugfs_create
> functions need not be error checked") to clean up unnecessary error checks
> without impacting the functionality.
>
> Fixes: 91581c4b3f29e ("gpio: virtuser: new virtual testing driver for the GPIO API")
> Link: https://lore.kernel.org/all/20220222154555.1.I26d364db7a007f8995e8f0dac978673bc8e9f5e2@changeid/ [1]
> Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
> ---

The commit you linked says: "In many cases (...)". This is not one of
these cases as this driver is completely useless without functional
debugfs entries so it very much makes sense to check the relevant
calls.

Bart