[<prev] [next>] [day] [month] [year] [list]
Message-ID: <8085f9c18ab06158b9adbbdadb8554c85972d390.1754774176.git.christophe.jaillet@wanadoo.fr>
Date: Sat, 9 Aug 2025 23:16:52 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Russell King <linux@...linux.org.uk>,
David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
Rob Clark <robin.clark@....qualcomm.com>
Cc: linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Russell King <rmk+kernel@....linux.org.uk>,
dri-devel@...ts.freedesktop.org
Subject: [PATCH] drm/armada: Use the correct prototype for a struct file_operations .write function
.write functions from struct file_operations return a ssize_t not an int.
This is maybe not an issue for architectures that use this driver, but it
is nicer to explicitly use the correct return type.
Fixes: 96f60e37dc66 ("DRM: Armada: Add Armada DRM driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
Spotted while looking at something else and trying to compile the file on a
x86_64 using:
make -j8 drivers/gpu/drm/armada/armada_debugfs.o
---
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index a763349dd89f..96aebd56272f 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -49,7 +49,7 @@ static int armada_debugfs_crtc_reg_open(struct inode *inode, struct file *file)
inode->i_private);
}
-static int armada_debugfs_crtc_reg_write(struct file *file,
+static ssize_t armada_debugfs_crtc_reg_write(struct file *file,
const char __user *ptr, size_t len, loff_t *off)
{
struct armada_crtc *dcrtc;
--
2.50.1
Powered by blists - more mailing lists