linux-kernel - Re: [PATCH v2] media: rkvdec: Remove redundant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1894144.QZUTf85G27@diego>
Date: Mon, 11 Aug 2025 16:37:27 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Detlev Casanova <detlev.casanova@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>
Cc: linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>
Subject: Re: [PATCH v2] media: rkvdec: Remove redundant

Am Montag, 11. August 2025, 16:03:45 Mitteleuropäische Sommerzeit schrieb Nicolas Dufresne:
> From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

verifíed the (new) definition of  pm_runtime_put_autosuspend()
Reviewed-by: Heiko Stuebner <heiko@...ech.de>

But the subject could use some work, I only got
	"[PATCH v2] media: rkvdec: Remove redundant"

so maybe make that
"media: rkvdec: Remove redundant pm_runtime_mark_last_busy"


Heiko

> ---
> Changes since V1:
>   - Re-applied since the driver have been moved out of staging
> ---
>  drivers/media/platform/rockchip/rkvdec/rkvdec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> index d707088ec0dc1f6a18b2d168ebdf20b443f2240e..445f7c92eee34f7d6f885bb519d9eb24313da548 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -765,7 +765,6 @@ static void rkvdec_job_finish(struct rkvdec_ctx *ctx,
>  {
>  	struct rkvdec_dev *rkvdec = ctx->dev;
>  
> -	pm_runtime_mark_last_busy(rkvdec->dev);
>  	pm_runtime_put_autosuspend(rkvdec->dev);
>  	rkvdec_job_finish_no_pm(ctx, result);
>  }
> 
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250811-rkvdec-redundant-pm-rebase-ed9b885eeadd
> 
> Best regards,
>