linux-kernel - Re: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfe92ca1-fdab-48f3-8410-e4435ab4f2f9@gmail.com>
Date: Mon, 11 Aug 2025 15:37:04 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Byungchul Park <byungchul@...com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel_team@...ynix.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 almasrymina@...gle.com, hawk@...nel.org, toke@...hat.com
Subject: Re: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with
 netmem_to_nmdesc()

On 8/11/25 05:23, Byungchul Park wrote:
> On Sun, Aug 10, 2025 at 08:39:42PM +0100, Pavel Begunkov wrote:
>> On 7/29/25 11:41, Byungchul Park wrote:
>>> Changes from RFC:
>>>        1. Optimize the implementation of netmem_to_nmdesc to use less
>>>           instructions (feedbacked by Pavel)
>>>
>>> ---8<---
>>>   From 6a0dbaecbf9a2425afe73565914eaa762c5d15c8 Mon Sep 17 00:00:00 2001
>>> From: Byungchul Park <byungchul@...com>
>>> Date: Tue, 29 Jul 2025 19:34:12 +0900
>>> Subject: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to_nmdesc()
>>>
>>> Now that we have struct netmem_desc, it'd better access the pp fields
>>> via struct netmem_desc rather than struct net_iov.
>>>
>>> Introduce netmem_to_nmdesc() for safely converting netmem_ref to
>>> netmem_desc regardless of the type underneath e.i. netmem_desc, net_iov.
>>>
>>> While at it, remove __netmem_clear_lsb() and make netmem_to_nmdesc()
>>> used instead.
>>
>> I'll ultimately need this in another tree as indicated in the
>> original diff, so I'll take it into a branch and send it out
> 
> Just curious.  What is the original diff?

It was this one:

https://lore.kernel.org/all/a7bd1e6f-b854-4172-a29a-3f0662c6fd6e@gmail.com/

-- 
Pavel Begunkov