linux-kernel - Re: [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfc57wlx.ffs@tglx>
Date: Mon, 11 Aug 2025 16:37:30 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Inochi Amaoto <inochiama@...il.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, Inochi Amaoto <inochiama@...il.com>, Saurabh
 Sengar <ssengar@...ux.microsoft.com>, Shradha Gupta
 <shradhagupta@...ux.microsoft.com>, Jonathan Cameron
 <Jonathan.Cameron@...ei.com>, Nicolin Chen <nicolinc@...dia.com>, Jason
 Gunthorpe <jgg@...pe.ca>, Chen Wang <unicorn_wang@...look.com>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, Yixun Lan
 <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)_parent

On Thu, Aug 07 2025 at 19:23, Inochi Amaoto wrote:

Please use 'function()' notation for functions. See

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html

I'm sure I pointed you to this documented at least three times in the
past. Do you think this was written for entertainment?

> Add helper irq_chip_startup_parent and irq_chip_shutdown_parent. The
> helper implement the default behavior in case irq_startup or irq_shutdown
> is not implemented for the parent interrupt chip, which will fallback
> to irq_chip_enable_parent or irq_chip_disable_parent if not available.

Also please use the documented structure for change logs. Starting with
'Add' is just wrong. See Documentation.