linux-kernel - Re: [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJoAnkBfLqKc7Frd@black.igk.intel.com>
Date: Mon, 11 Aug 2025 16:39:26 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Saurabh Sengar <ssengar@...ux.microsoft.com>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Jonathan Cameron <Jonathan.Cameron@...ei.com>,
	Nicolin Chen <nicolinc@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
	Chen Wang <unicorn_wang@...look.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, Yixun Lan <dlan@...too.org>,
	Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)_parent

On Thu, Aug 07, 2025 at 07:23:22PM +0800, Inochi Amaoto wrote:
> Add helper irq_chip_startup_parent and irq_chip_shutdown_parent. The

irq_chip_startup_parent() and irq_chip_shutdown_parent()

> helper implement the default behavior in case irq_startup or irq_shutdown

In the same way...

> is not implemented for the parent interrupt chip, which will fallback
> to irq_chip_enable_parent or irq_chip_disable_parent if not available.

In the same way...


...

> +/**
> + * irq_chip_startup_parent - Startup the parent interrupt
> + * @data:	Pointer to interrupt specific data
> + *
> + * Invokes the irq_startup() callback of the parent if available or falls
> + * back to irq_chip_enable_parent().

kernel-doc validator is not happy: Missing Return section.

> + */

-- 
With Best Regards,
Andy Shevchenko