linux-kernel - Re: [PATCH 3/4] irqchip/sg2042-msi: Fix broken affinity setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJoBdHlV6ZKcFry5@black.igk.intel.com>
Date: Mon, 11 Aug 2025 16:43:00 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Saurabh Sengar <ssengar@...ux.microsoft.com>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Jonathan Cameron <Jonathan.Cameron@...ei.com>,
	Nicolin Chen <nicolinc@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
	Chen Wang <unicorn_wang@...look.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, Yixun Lan <dlan@...too.org>,
	Longbin Li <looong.bin@...il.com>, Han Gao <rabenda.cn@...il.com>
Subject: Re: [PATCH 3/4] irqchip/sg2042-msi: Fix broken affinity setting

On Thu, Aug 07, 2025 at 07:23:24PM +0800, Inochi Amaoto wrote:
> When using NVME on SG2044, the NVME always complains "I/O tag XXX
> (XXX) QID XX timeout, completion polled", which is caused by the
> broken handler of the sg2042-msi driver.
> 
> As PLIC driver can only setting affinity when enabling, the sg2042-msi
> does not properly handled affinity setting previously and enable irq in
> an unexpected executing path.
> 
> Since the PCI template domain supports irq_startup/irq_shutdown, set
> irq_chip_[startup/shutdown]_parent for irq_startup/irq_shutdown. So
> the irq can be started properly.

> Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
> Reported-by: Han Gao <rabenda.cn@...il.com>

Closes ?

> Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>

...

>  #define SG2042_MSI_FLAGS_REQUIRED (MSI_FLAG_USE_DEF_DOM_OPS |	\
> -				   MSI_FLAG_USE_DEF_CHIP_OPS)
> +				   MSI_FLAG_USE_DEF_CHIP_OPS |	\
> +				   MSI_FLAG_PCI_MSI_MASK_PARENT |\

Can we indent \ to be on the same column (using TABs)?

> +				   MSI_FLAG_PCI_MSI_STARTUP_PARENT)

...

>  #define SG2044_MSI_FLAGS_REQUIRED (MSI_FLAG_USE_DEF_DOM_OPS |	\
> -				   MSI_FLAG_USE_DEF_CHIP_OPS)
> +				   MSI_FLAG_USE_DEF_CHIP_OPS |	\
> +				   MSI_FLAG_PCI_MSI_MASK_PARENT |\
> +				   MSI_FLAG_PCI_MSI_STARTUP_PARENT)

Ditto.

-- 
With Best Regards,
Andy Shevchenko