linux-kernel - Re: [PATCH v9 7/7] rust: irq: add &Device<Bound> argument to irq callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJokQTM97xBMXxVo@Mac.home>
Date: Mon, 11 Aug 2025 10:11:29 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Krzysztof Wilczy´nski <kwilczynski@...nel.org>,
	Benno Lossin <lossin@...nel.org>, linux-kernel@...r.kernel.org,
	rust-for-linux@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v9 7/7] rust: irq: add &Device<Bound> argument to irq
 callbacks

On Mon, Aug 11, 2025 at 02:00:47PM -0300, Daniel Almeida wrote:
> 
> 
> > On 11 Aug 2025, at 13:03, Daniel Almeida <daniel.almeida@...labora.com> wrote:
> > 
> > From: Alice Ryhl <aliceryhl@...gle.com>
> > 
> > When working with a bus device, many operations are only possible while
> > the device is still bound. The &Device<Bound> type represents a proof in
> > the type system that you are in a scope where the device is guaranteed
> > to still be bound. Since we deregister irq callbacks when unbinding a
> > device, if an irq callback is running, that implies that the device has
> > not yet been unbound.
> > 
> > To allow drivers to take advantage of that, add an additional argument
> > to irq callbacks.
> > 
> > Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
> 
> Sorry. I forgot to add my SOB here.
> 
> 
> Perhaps this can be added when the patch is being applied in order to cut down on the
> number of versions, and therefore avoid the extra noise? Otherwise let me know.
> 

I think it's fine to submit with only Alice's SoB, my understanding is
that you won't necessarily need to add your SoB if you are simply
re-submitting a patch (with minor changes). There are changes where your
SoB is needed: 1) you change the code significantly, in which case, you
may also need to add "Co-Developed-by" for Alice as well; 2) you're
submitting the patch as a maintainer, and you have queued that patch
already somewhere in your tree, in this case SoB shows how the patch
flows around. Of course, either case it's better to sync with Alice
first, which I believe you have already done that.

While I'm at it,

Reviewed-by: Boqun Feng <boqun.feng@...il.com>

Regards,
Boqun

> Signed-off-by: Daniel Almeida <daniel.almeida@...labora.com>
> 
>