linux-kernel - Re: [PATCH V2 1/4] dt-bindings: ufs: qcom: Document MCQ register space for UFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c957d52-8f79-4d2d-8463-770b9121c3ce@kernel.org>
Date: Mon, 11 Aug 2025 19:11:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bjorn Andersson <andersson@...nel.org>,
 Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
Cc: mani@...nel.org, alim.akhtar@...sung.com, avri.altman@....com,
 bvanassche@....org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, konradybcio@...nel.org, agross@...nel.org,
 James.Bottomley@...senpartnership.com, martin.petersen@...cle.com,
 linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/4] dt-bindings: ufs: qcom: Document MCQ register
 space for UFS

On 11/08/2025 17:02, Bjorn Andersson wrote:
> On Mon, Aug 11, 2025 at 08:01:36PM +0530, Ram Kumar Dwivedi wrote:
>> Document Multi-Circular Queue (MCQ) register space for
>> Qualcomm UFS controllers.
>>
>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
>> ---
>>  .../devicetree/bindings/ufs/qcom,ufs.yaml        | 16 ++++++++++------
>>  1 file changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index 6c6043d9809e..daf681b0e23b 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -89,9 +89,13 @@ properties:
>>      maxItems: 2
>>  
>>    reg-names:
>> -    items:
>> -      - const: std
>> -      - const: ice
>> +    oneOf:
>> +      - items:
>> +          - const: std
>> +          - const: ice
>> +      - items:
>> +          - const: ufs_mem
>> +          - const: mcq
> 
> So you can either "std" and "ice", or "ufs_mem" and "mcq".
> 
> Does this imply that "std" changes name to "ufs_mem"? Why?
> Is MCQ incompatible with ICE?
I commented on v1 what has to be fixed. I also said I will provide the
actual fix and then this is sent ignoring my comments and ignoring my fix.

So no, this does not get fixed.

NAK.

Best regards,
Krzysztof