linux-kernel - Re: [PATCH] binder: Add missing module description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJoqFKYpWkDCiIJp@google.com>
Date: Mon, 11 Aug 2025 17:36:20 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Salvatore Bonaccorso <carnil@...ian.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <christian@...uner.io>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Ben Hutchings <benh@...ian.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: Add missing module description

On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> During build modpost issues a warning:
> 
>     # MODPOST Module.symvers
>        ./scripts/mod/modpost -M -m -b        -o Module.symvers -n -T modules.order vmlinux.o
>     WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
> 
> Fix this by adding the missing module description.

I'm not against having a description but binder is not tristate. Judging
from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
I'm not sure you would be able to reproduce the warn.

> 
> Reported-by: Ben Hutchings <benh@...ian.org>
> Link: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1587
> Suggested-by: Ben Hutchings <benh@...ian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@...ian.org>
> ---
>  drivers/android/binder.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 312b462e349d..0c2e38ff3a3b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -7090,3 +7090,4 @@ device_initcall(binder_init);
>  #include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Android Binder IPC Driver");
> -- 
> 2.50.1
>