linux-kernel - Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5732b907-ccb8-4302-8fd7-ded63a5d852b@baylibre.com>
Date: Mon, 11 Aug 2025 14:18:10 -0500
From: David Lechner <dlechner@...libre.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Andy Shevchenko <andy@...nel.org>,
 Angelo Dureghello <adureghello@...libre.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate_hz on
 adaq4381-4

On 8/11/25 2:07 PM, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 8:32 PM David Lechner <dlechner@...libre.com> wrote:
>>
>> Add max_conversion_rate_hz to the chip info for "adaq4381-4". Without
>> this, the driver fails to probe because it tries to set the initial
>> sample rate to 0 Hz, which is not valid.
> 
> ...
> 
>> +       .max_conversion_rate_hz = 4 * MEGA,
> 
> MEGA --> HZ_PER_MHZ

If we do this, we should fix up all of the other similar ones
in a separate patch. So I would leave this patch as-is.

> 
> With that done
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> 
>