linux-kernel - Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf3s1ftm0wBPbeTuKgO0W22ndpdcGE+zSMSHD=4z1O4Xg@mail.gmail.com>
Date: Mon, 11 Aug 2025 21:22:28 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Andy Shevchenko <andy@...nel.org>, 
	Angelo Dureghello <adureghello@...libre.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate_hz on adaq4381-4

On Mon, Aug 11, 2025 at 9:18 PM David Lechner <dlechner@...libre.com> wrote:
> On 8/11/25 2:07 PM, Andy Shevchenko wrote:
> > On Mon, Aug 11, 2025 at 8:32 PM David Lechner <dlechner@...libre.com> wrote:

...

> >> +       .max_conversion_rate_hz = 4 * MEGA,
> >
> > MEGA --> HZ_PER_MHZ
>
> If we do this, we should fix up all of the other similar ones
> in a separate patch. So I would leave this patch as-is.

Will it happen sooner?

> > With that done
> > Reviewed-by: Andy Shevchenko <andy@...nel.org>

I leave this to Jonathan because in spite of being a fix I still think
it's better to use an appropriate multiplier (also note, MEGA appeared
in the kernel much later than HZ_PER_* constants, which sounds in my
favour).

-- 
With Best Regards,
Andy Shevchenko