linux-kernel - Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250816143303.6fe40510@jic23-huawei>
Date: Sat, 16 Aug 2025 14:33:03 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Michael Hennerich
 <michael.hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Angelo Dureghello
 <adureghello@...libre.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate_hz on
 adaq4381-4

On Mon, 11 Aug 2025 21:22:28 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Mon, Aug 11, 2025 at 9:18 PM David Lechner <dlechner@...libre.com> wrote:
> > On 8/11/25 2:07 PM, Andy Shevchenko wrote:  
> > > On Mon, Aug 11, 2025 at 8:32 PM David Lechner <dlechner@...libre.com> wrote:  
> 
> ...
> 
> > >> +       .max_conversion_rate_hz = 4 * MEGA,  
> > >
> > > MEGA --> HZ_PER_MHZ  
> >
> > If we do this, we should fix up all of the other similar ones
> > in a separate patch. So I would leave this patch as-is.  
> 
> Will it happen sooner?
> 
> > > With that done
> > > Reviewed-by: Andy Shevchenko <andy@...nel.org>  
> 
> I leave this to Jonathan because in spite of being a fix I still think
> it's better to use an appropriate multiplier (also note, MEGA appeared
> in the kernel much later than HZ_PER_* constants, which sounds in my
> favour).
> 

I'll take this as is.  A future tidy up might switch them all over.
I've always been in two minds as to whether the unit specific ones
are helpful for this case where one of the scales is 1.

Applied to the fixes-togreg branch of iio.git.

Jonathan