linux-kernel - Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24759bdb-b427-47a7-b9c3-724a11d0162e@web.de>
Date: Mon, 11 Aug 2025 09:02:22 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Scott Guo <scottzhguo@...cent.com>,
 Phillip Lougher <phillip@...ashfs.org.uk>
Cc: scott_gzh@....com, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill_super

> If sb_min_blocksize returns 0, -EINVAL was returned without freeing
> sb->s_fs_info, causing mem leak.

                         memory?

How do you think about to append parentheses to the function name (in the summary phrase)?

> Fix it by goto failed_mount.

By the way:
I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem”
so that another bit of exception handling code can be shared at the end
of this function implementation.
https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466

Regards,
Markus