linux-kernel - Re: [PATCH v3 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250811-bittern-of-abstract-prestige-aaeda9@kuoka>
Date: Mon, 11 Aug 2025 09:55:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aman Kumar Pandey <aman.kumarpandey@....com>
Cc: linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org, 
	alexandre.belloni@...tlin.com, krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, 
	devicetree@...r.kernel.org, broonie@...nel.org, lee@...nel.org, vikash.bansal@....com, 
	priyanka.jain@....com, shashank.rebbapragada@....com, Frank.Li@....com
Subject: Re: [PATCH v3 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

On Fri, Aug 08, 2025 at 04:20:32PM +0300, Aman Kumar Pandey wrote:
> +        hub@70,236153000c2 {
> +            reg = <0x70 0x236 0x3000c2>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            assigned-address = <0x50>;
> +
> +            cp0-ldo-microvolt = <1800000>;

So you just duplicated regulators?

> +            cp1-ldo-microvolt = <1800000>;
> +            tp0145-ldo-microvolt = <1800000>;
> +            tp2367-ldo-microvolt = <1800000>;
> +            tp0145-pullup-ohm = <1000>;
> +            tp2367-pullup-ohm = <1000>;
> +            cp0-io-strength-ohm = <50>;
> +            cp1-io-strength-ohm = <50>;
> +            tp0145-io-strength-ohm = <50>;
> +            tp2367-io-strength-ohm = <50>;
> +            cp0-supply = <&cp0>;
> +            tp0145-supply = <&tp0145>;
> +
> +            regulators {
> +              cp0 {

Messed indentation

> +                regulator-name = "cp0";
> +                regulator-min-microvolt = <1000000>;
> +                regulator-max-microvolt = <1800000>;
> +              };
> +
> +              cp1 {
> +                regulator-name = "cp1";
> +                regulator-min-microvolt = <1000000>;
> +                regulator-max-microvolt = <1800000>;
> +              };
> +
> +              tp0145 {
> +                regulator-name = "tp0145";
> +                regulator-min-microvolt = <1000000>;
> +                regulator-max-microvolt = <1800000>;
> +              };
> +
> +              tp2367 {
> +                regulator-name = "tp2367";
> +                regulator-min-microvolt = <1000000>;
> +                regulator-max-microvolt = <1800000>;
> +              };
> +            };
> +
> +            target-port@0 {
> +                reg = <0x0>;
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +                mode = "smbus";
> +                pullup-enable;
> +
> +                eeprom@57 {
> +                    compatible = "atmel,24c32";
> +                    reg = <0x57>;
> +                    pagesize = <32>;
> +                    wp-gpios = <&gpio2 2 0>;
> +                    num-addresses = <8>;
> +                };
> +            };
> +
> +            target-port@2 {
> +                reg = <0x2>;
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +                mode = "i3c";
> +                pullup-enable;
> +
> +                sensor@68,39200144004 {
> +                  reg = <0x68 0x392 0x144004>;
> +                  assigned-address = <0xa>;
> +                };
> +            };
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4262e8d833c4..b33e90030188 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15477,6 +15477,14 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>  F:	sound/soc/codecs/tfa989x.c
>  
> +NXP P3H2X4X I3C-HUB DRIVER

Does not look ordered according to rules in this file.

Best regards,
Krzysztof