linux-kernel - Re: [PATCH v3 2/2] mfd: i3c: Add driver for NXP P3H2x4x i3c-hub device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250811-peculiar-kind-condor-ce8cd6@kuoka>
Date: Mon, 11 Aug 2025 09:01:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aman Kumar Pandey <aman.kumarpandey@....com>
Cc: linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org, 
	alexandre.belloni@...tlin.com, krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, 
	devicetree@...r.kernel.org, broonie@...nel.org, lee@...nel.org, vikash.bansal@....com, 
	priyanka.jain@....com, shashank.rebbapragada@....com, Frank.Li@....com
Subject: Re: [PATCH v3 2/2] mfd: i3c: Add driver for NXP P3H2x4x i3c-hub
 device

On Fri, Aug 08, 2025 at 04:20:33PM +0300, Aman Kumar Pandey wrote:
> +static int p3h2x4x_device_probe_i3c(struct i3c_device *i3cdev)
> +{
> +	struct p3h2x4x_dev *p3h2x4x;
> +	int ret;
> +
> +	p3h2x4x = devm_kzalloc(&i3cdev->dev, sizeof(*p3h2x4x), GFP_KERNEL);
> +	if (!p3h2x4x)
> +		return -ENOMEM;
> +
> +	i3cdev_set_drvdata(i3cdev, p3h2x4x);
> +
> +	p3h2x4x->regmap = devm_regmap_init_i3c(i3cdev, &p3h2x4x_regmap_config);
> +	if (IS_ERR(p3h2x4x->regmap)) {
> +		ret = PTR_ERR(p3h2x4x->regmap);

Drop, don't create useless assignments.

> +		return dev_err_probe(&i3cdev->dev, ret, "Failed to register I3C HUB regmap\n");

Best regards,
Krzysztof