linux-kernel - Re: [PATCH v2] mm/numa_memblks: Use pr_debug instead of printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJmjXABrInqumY1-@kernel.org>
Date: Mon, 11 Aug 2025 11:01:32 +0300
From: Mike Rapoport <rppt@...nel.org>
To: pratyush.brahma@....qualcomm.com
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Joshua Hahn <joshua.hahnjy@...il.com>
Subject: Re: [PATCH v2] mm/numa_memblks: Use pr_debug instead of
 printk(KERN_DEBUG)

On Mon, Aug 11, 2025 at 12:13:54PM +0530, pratyush.brahma@....qualcomm.com wrote:
> From: Pratyush Brahma <pratyush.brahma@....qualcomm.com>
> 
> Replace the direct usage of printk(KERN_DEBUG ...) with pr_debug(...) to
> align with the consistent `pr_*` API usage within the file.
> 
> Reviewed-by: Joshua Hahn <joshua.hahnjy@...il.com>
> Signed-off-by: Pratyush Brahma <pratyush.brahma@....qualcomm.com>
> ---
> Changes in v2:
> - Removed printk header as suggested by Joshua.
> - Link to v1: https://lore.kernel.org/r/20250808-numa-dbg-v1-1-2ddd1ec634aa@oss.qualcomm.com
> ---
>  mm/numa_memblks.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
> index 541a99c4071a67e5b0ef66f4136dee268a880003..ed6fcfca057ab4c9a8aa26cd1929551b4ded4a5b 100644
> --- a/mm/numa_memblks.c
> +++ b/mm/numa_memblks.c
> @@ -2,7 +2,6 @@
>  
>  #include <linux/array_size.h>
>  #include <linux/sort.h>
> -#include <linux/printk.h>

Please don't, pr_debug is defined there.

>  #include <linux/memblock.h>
>  #include <linux/numa.h>
>  #include <linux/numa_memblks.h>
> @@ -76,7 +75,7 @@ static int __init numa_alloc_distance(void)
>  		for (j = 0; j < cnt; j++)
>  			numa_distance[i * cnt + j] = i == j ?
>  				LOCAL_DISTANCE : REMOTE_DISTANCE;
> -	printk(KERN_DEBUG "NUMA: Initialized distance table, cnt=%d\n", cnt);
> +	pr_debug("NUMA: Initialized distance table, cnt=%d\n", cnt);
>  
>  	return 0;
>  }
> 
> ---
> base-commit: 479058002c32b77acac43e883b92174e22c4be2d
> change-id: 20250808-numa-dbg-62a8b2092c56
> 
> Best regards,
> -- 
> Pratyush Brahma <pratyush.brahma@....qualcomm.com>
> 

-- 
Sincerely yours,
Mike.