linux-kernel - [RFC] wifi: iwlwifi: mei: Remove unused flexible-array member in struct iwl_sap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbc03dee-273a-4c75-a8bb-fbc6ae48d26d@embeddedor.com>
Date: Mon, 11 Aug 2025 17:23:56 +0900
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Miri Korenblit <miriam.rachel.korenblit@...el.com>,
 Johannes Berg <johannes@...solutions.net>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RFC] wifi: iwlwifi: mei: Remove unused flexible-array member in
 struct iwl_sap_hdr?

Hi all,

At first sight, it seems that the flexible-array member `payload`
in the struct below it's not being used:

drivers/net/wireless/intel/iwlwifi/mei/sap.h:
298 /**
299  * struct iwl_sap_hdr - prefixes any SAP message
300  * @type: See &enum iwl_sap_msg.
301  * @len: The length of the message (header not included).
302  * @seq_num: For debug.
303  * @payload: The payload of the message.
304  */
305 struct iwl_sap_hdr {
306         __le16 type;
307         __le16 len;
308         __le32 seq_num;
309         u8 payload[];
310 };

If we remove it, we'd get rid of 14 of the following type of warnings:

drivers/net/wireless/intel/iwlwifi/mei/sap.h:318:28: warning: structure containing a flexible array member is not at the end of another structure 
[-Wflex-array-member-not-at-end]

Is there any case where this array is actually used that I might
be missing?

Thanks!
-Gustavo