linux-kernel - Re: [RFC] wifi: iwlwifi: mei: Remove unused flexible-array member in struct iwl_sap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f8037dc97958e06dfb08d75fce982c1e4e36068.camel@sipsolutions.net>
Date: Mon, 25 Aug 2025 10:20:09 +0200
From: Johannes Berg <johannes@...solutions.net>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Miri Korenblit
	 <miriam.rachel.korenblit@...el.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] wifi: iwlwifi: mei: Remove unused flexible-array member
 in struct iwl_sap_hdr?

On Mon, 2025-08-11 at 17:23 +0900, Gustavo A. R. Silva wrote:
> Hi all,
> 
> At first sight, it seems that the flexible-array member `payload`
> in the struct below it's not being used:
> 
> drivers/net/wireless/intel/iwlwifi/mei/sap.h:
> 298 /**
> 299  * struct iwl_sap_hdr - prefixes any SAP message
> 300  * @type: See &enum iwl_sap_msg.
> 301  * @len: The length of the message (header not included).
> 302  * @seq_num: For debug.
> 303  * @payload: The payload of the message.
> 304  */
> 305 struct iwl_sap_hdr {
> 306         __le16 type;
> 307         __le16 len;
> 308         __le32 seq_num;
> 309         u8 payload[];
> 310 };
> 
> If we remove it, we'd get rid of 14 of the following type of warnings:
> 
> drivers/net/wireless/intel/iwlwifi/mei/sap.h:318:28: warning: structure containing a flexible array member is not at the end of another structure 
> [-Wflex-array-member-not-at-end]
> 
> Is there any case where this array is actually used that I might
> be missing?

Check if it builds? But I don't see it used in our internal (and
possibly more recent) version of this either.

johannes