linux-kernel - Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b41749ae-640b-4911-976f-8aa36d40ed6b@kernel.org>
Date: Mon, 11 Aug 2025 13:02:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ot_shunxi.zhang@...iatek.com, Eddie Huang <eddie.huang@...iatek.com>,
 Sean Wang <sean.wang@...iatek.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Matthias Brugger <matthias.bgg@...il.com>, Lee Jones <lee@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
 sirius.wang@...iatek.com, vince-wl.liu@...iatek.com, jh.hsu@...iatek.com
Subject: Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU
 register

On 11/08/2025 10:15, ot_shunxi.zhang@...iatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> 
> This patch adds new bit definitions for the RTC_BBPU register in the

Why? There is no user of these. Don't add useless defines.

> mt6397 RTC header file. The following bit definitions are introduced:

Hm?

> 
> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> ---
>  include/linux/mfd/mt6397/rtc.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index 27883af44f87..001cef6b7302 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h
> @@ -15,8 +15,11 @@
>  #include <linux/rtc.h>
>  
>  #define RTC_BBPU               0x0000
> +#define RTC_BBPU_PWREN         BIT(0)
> +#define RTC_BBPU_CLR           BIT(1)
> +#define RTC_BBPU_RESET_AL      BIT(3)
>  #define RTC_BBPU_CBUSY         BIT(6)
> -#define RTC_BBPU_KEY            (0x43 << 8)
> +#define RTC_BBPU_KEY           (0x43 << 8)


Why?



Best regards,
Krzysztof