linux-kernel - Re: [PATCH] mm: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e01b83c-17f7-40b7-a9ba-3118b281a72d@vivo.com>
Date: Tue, 12 Aug 2025 21:22:51 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Harry Yoo <harry.yoo@...cle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Andrew Morton <akpm@...ux-foundation.org>, Will Deacon <will@...nel.org>,
 "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Nick Piggin
 <npiggin@...il.com>, Peter Zijlstra <peterz@...radead.org>,
 David Hildenbrand <david@...hat.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Rik van Riel
 <riel@...riel.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 Vlastimil Babka <vbabka@...e.cz>, Uladzislau Rezki <urezki@...il.com>,
 linux-fsdevel@...r.kernel.org, sj@...nel.org, damon@...ts.linux.dev,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] mm: remove redundant __GFP_NOWARN

在 2025/8/12 21:11, Harry Yoo 写道:
> [You don't often get email from harry.yoo@...cle.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, Aug 12, 2025 at 05:57:46PM +0800, Qianfeng Rong wrote:
>> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
>> GFP_NOWAIT implicitly include __GFP_NOWARN.
>>
>> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
>> `GFP_NOWAIT | __GFP_NOWARN`) is now redundant.  Let's clean up these
>> redundant flags across subsystems.
>>
>> No functional changes.
>>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
>> ---
> Maybe
>
> .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
>                          __GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT,
>
> in mm/damon/paddr.c also can be cleaned up to
>
> .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
>                          | __GFP_NOMEMALLOC | GFP_NOWAIT,
>
> ?
Thanks for the reminder.  I did miss one modification spot.  After checking,
I found this code section was moved to mm/damon/ops-common.c.  I'll submit
v2 immediately.

Best regards,
Qianfeng
>
> With or without that:
>
> Reviewed-by: Harry Yoo <harry.yoo@...cle.com>
>
> --
> Cheers,
> Harry / Hyeonggon
>