linux-kernel - Re: [PATCH] mm: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250812170933.56674-1-sj@kernel.org>
Date: Tue, 12 Aug 2025 10:09:33 -0700
From: SeongJae Park <sj@...nel.org>
To: Harry Yoo <harry.yoo@...cle.com>
Cc: SeongJae Park <sj@...nel.org>,
	Qianfeng Rong <rongqianfeng@...o.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Will Deacon <will@...nel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
	Nick Piggin <npiggin@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	David Hildenbrand <david@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Rik van Riel <riel@...riel.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Uladzislau Rezki <urezki@...il.com>,
	linux-fsdevel@...r.kernel.org,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH] mm: remove redundant __GFP_NOWARN

On Tue, 12 Aug 2025 22:11:16 +0900 Harry Yoo <harry.yoo@...cle.com> wrote:

> On Tue, Aug 12, 2025 at 05:57:46PM +0800, Qianfeng Rong wrote:
> > Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
> > GFP_NOWAIT implicitly include __GFP_NOWARN.
> > 
> > Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
> > `GFP_NOWAIT | __GFP_NOWARN`) is now redundant.  Let's clean up these
> > redundant flags across subsystems.
> > 
> > No functional changes.
> > 
> > Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> > ---
> 
> Maybe
> 
> .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
>                         __GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT,
> 
> in mm/damon/paddr.c also can be cleaned up to
> 
> .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
>                         | __GFP_NOMEMALLOC | GFP_NOWAIT, 
> 
> ?

Thank you for catching this, Harry!

FYI, the code has moved into mm/damon/ops-common.c by commit 13dde31db71f
("mm/damon: move migration helpers from paddr to ops-common").  Please feel
free to make the cleanup if anyone willing to.


Thanks,
SJ

[...]