linux-kernel - Re: [PATCH RFC v2 1/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292b023-e575-4270-9cbe-8943ab137eb5@kernel.org>
Date: Tue, 12 Aug 2025 16:45:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v2 1/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5

On 12/08/2025 16:39, Krzysztof Kozlowski wrote:
>>>>> +
>>>>> +				opp-533333334 {
>>>>> +					opp-hz = /bits/ 64 <533333334>;
>>>>> +					required-opps = <&rpmhpd_opp_nom>,
>>>>> +							<&rpmhpd_opp_nom>;
>>>>> +				};
>>>>
>>>> There's an additional OPP: 570 MHz @ NOM_L1
>>>>
>>>> +Dmitry, Vikash, please make sure you're OK with the iommu entries
>>>
>>>
>>> That opp has troubles with clock, so would need some fixed in videocc or
>>> iris, AFAIK. Otherwise you will just PM OPP failures. I can add it
>>> though, at the end  DTS should be independent of drivers. :)
>>
>> Weird, there's an entry in the frequency table for it (well, * 3 the
>> rate) and it comes out of the same PLL as other ones.. what sort of
> 
> You mean freq_tbl in P_VIDEO_CC_PLL0_OUT_MAIN? Yeah, I also saw that.
> 
>> opp failures do you see?
> 
> Only:
> 
> [    9.306006] qcom-iris aa00000.video-codec: dev_pm_opp_set_rate:
> failed to find OPP for freq 630000000 (-34)
> [    9.316078] qcom-iris aa00000.video-codec: power on failed
> [    9.322001] qcom-iris aa00000.video-codec: core init failed

But I misunderstood you - I thought you want to replace 630, to match
downstream driver. If just added, then it's fine.

Best regards,
Krzysztof