linux-kernel - Re: [PATCH 3/4] soc: fsl: qe: Add support of IRQ in QE GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd39f667-9153-4c62-9993-2156f2cebf1d@kernel.org>
Date: Tue, 12 Aug 2025 17:30:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 Qiang Zhao <qiang.zhao@....com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 3/4] soc: fsl: qe: Add support of IRQ in QE GPIO

On 12/08/2025 13:02, Christophe Leroy wrote:
>  
>  	qe_gc = kzalloc(sizeof(*qe_gc), GFP_KERNEL);
>  	if (!qe_gc) {
> @@ -313,6 +324,14 @@ static int qe_gpio_probe(struct platform_device *ofdev)
>  
>  	spin_lock_init(&qe_gc->lock);
>  
> +	if (!of_property_read_u32(np, "fsl,qe-gpio-irq-mask", &mask)) {

Undocumented ABI. You cannot add such stuff and testing your DTS would
point it out.


Best regards,
Krzysztof