linux-kernel - Re: [PATCH v3 2/2] mm: swap.h: Remove deleted field from comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMgjq7D7MBK467=xYBXPZcBbY0_6n031P3rwnE28foP5gz7N7Q@mail.gmail.com>
Date: Wed, 13 Aug 2025 01:04:06 +0800
From: Kairui Song <ryncsn@...il.com>
To: Chris Li <chrisl@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Kemeng Shi <shikemeng@...weicloud.com>, 
	Nhat Pham <nphamcs@...il.com>, Baoquan He <bhe@...hat.com>, Barry Song <baohua@...nel.org>, 
	"Huang, Ying" <ying.huang@...ux.alibaba.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mm: swap.h: Remove deleted field from comments

On Tue, Aug 12, 2025 at 3:26 PM Chris Li <chrisl@...nel.org> wrote:
>
> The comment for struct swap_info_struct.lock incorrectly mentions fields
> that have already been deleted from the structure.
>
> Updates the comments to accurately reflect the current struct
> swap_info_struct.
>
> There is no functional change.
>
> Signed-off-by: Chris Li <chrisl@...nel.org>
> ---
>  include/linux/swap.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index a060d102e0d1..c2da85cb7fe7 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -320,11 +320,8 @@ struct swap_info_struct {
>         struct completion comp;         /* seldom referenced */
>         spinlock_t lock;                /*
>                                          * protect map scan related fields like
> -                                        * swap_map, lowest_bit, highest_bit,
> -                                        * inuse_pages, cluster_next,
> -                                        * cluster_nr, lowest_alloc,
> -                                        * highest_alloc, free/discard cluster
> -                                        * list. other fields are only changed
> +                                        * swap_map, inuse_pages and all cluster
> +                                        * lists. other fields are only changed
>                                          * at swapon/swapoff, so are protected
>                                          * by swap_lock. changing flags need
>                                          * hold this lock and swap_lock. If
>
> --
> 2.43.0
>

Thanks.

Reviewed-by: Kairui Song <kasong@...cent.com>