linux-kernel - [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio button setting at startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250812223502.1356426-1-rdunlap@infradead.org>
Date: Tue, 12 Aug 2025 15:35:02 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org
Cc: Randy Dunlap <rdunlap@...radead.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio button setting at startup

When qconf (xconfig) exits, it saves the current Option settings
for Show Name, Show Debug Info, and Show {Normal|All|Prompt} Options.
When it is next run, it loads these Option settings from its
config file. It correctly shows the flag settings for Show Name
and Show Debug Info, but it does not show which of the 3 Show...Options
is set. This can lead to confusing output, e.g., if the user thinks
that xconfig is in Show All Options mode but kconfig options which
have an unmet dependency are still being listed.

Add code to show the radio button for the current Show...Options
mode during startup so that it will reflect the current config
setting.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
Nathan, Nicolas: do you want me to ask someone else to merge this?
  I don't mind doing that;
  or throw it into your tree and see what breaks.

I know next to nothing about the Qt toolkit, so any comments or
testing are appreciated. There could easily be a better fix for this.
Thanks.

Cc: Nathan Chancellor <nathan@...nel.org>
Cc: Nicolas Schier <nicolas@...sle.eu>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>

 scripts/kconfig/qconf.cc |   13 +++++++++++++
 1 file changed, 13 insertions(+)

--- linux-next-20250807.orig/scripts/kconfig/qconf.cc
+++ linux-next-20250807/scripts/kconfig/qconf.cc
@@ -1377,6 +1377,19 @@ ConfigMainWindow::ConfigMainWindow(void)
 	ConfigList::showPromptAction = new QAction("Show Prompt Options", optGroup);
 	ConfigList::showPromptAction->setCheckable(true);

+	switch (configList->optMode) {
+	case allOpt:
+		ConfigList::showAllAction->setChecked(true);
+		break;
+	case promptOpt:
+		ConfigList::showPromptAction->setChecked(true);
+		break;
+	case normalOpt:
+	default:
+		ConfigList::showNormalAction->setChecked(true);
+		break;
+	}
+
 	QAction *showDebugAction = new QAction("Show Debug Info", this);
 	  showDebugAction->setCheckable(true);
 	connect(showDebugAction, &QAction::toggled,