linux-kernel - Re: [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio button setting at startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKDS1w_2yHd3Om26@levanger>
Date: Sat, 16 Aug 2025 20:49:59 +0200
From: Nicolas Schier <nsc@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio
 button setting at startup

On Tue, Aug 12, 2025 at 03:35:02PM -0700, Randy Dunlap wrote:
> When qconf (xconfig) exits, it saves the current Option settings
> for Show Name, Show Debug Info, and Show {Normal|All|Prompt} Options.
> When it is next run, it loads these Option settings from its
> config file. It correctly shows the flag settings for Show Name
> and Show Debug Info, but it does not show which of the 3 Show...Options
> is set. This can lead to confusing output, e.g., if the user thinks
> that xconfig is in Show All Options mode but kconfig options which
> have an unmet dependency are still being listed.
> 
> Add code to show the radio button for the current Show...Options
> mode during startup so that it will reflect the current config
> setting.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> Nathan, Nicolas: do you want me to ask someone else to merge this?
>   I don't mind doing that;
>   or throw it into your tree and see what breaks.
> 
> I know next to nothing about the Qt toolkit, so any comments or
> testing are appreciated. There could easily be a better fix for this.
> Thanks.

Thanks for the fix!  I cannot review this properly but reasoning is
straightforward and testing reveals that its really useful.

Tested-by: Nicolas Schier <nsc@...nel.org>
Acked-by: Nicolas Schier <nsc@...nel.org>


Nathan,  can you take this into kbuild-next?

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)