linux-kernel - Re: [PATCH v2 2/2] powerpc: pci-ioda: Optimize pnv_ioda_pick_m64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4adce2fdf58f74e42949528e1d6c4345337706b7.camel@linux.ibm.com>
Date: Tue, 12 Aug 2025 13:45:32 +1000
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Yury Norov <yury.norov@...il.com>,
        "Jiri Slaby (SUSE)"	
 <jirislaby@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael
 Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy	 <christophe.leroy@...roup.eu>,
        Thomas Gleixner
 <tglx@...utronix.de>,
        Frederic Barrat <fbarrat@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] powerpc: pci-ioda: Optimize
 pnv_ioda_pick_m64_pe()

On Mon, 2025-08-11 at 12:51 -0400, Yury Norov wrote:
> From: "Yury Norov (NVIDIA)" <yury.norov@...il.com>
> 
> bitmap_empty() in pnv_ioda_pick_m64_pe() is O(N) and useless because
> the following find_next_bit() does the same work.
> 
> Drop it, and while there replace a while() loop with the dedicated
> for_each_set_bit().
> 
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@...il.com>

Reviewed-by: Andrew Donnellan <ajd@...ux.ibm.com>

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited