linux-kernel - Re: [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in pnv_ioda_pick_m64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ0xJenyDJcZILt-@yury>
Date: Wed, 13 Aug 2025 20:43:17 -0400
From: Yury Norov <yury.norov@...il.com>
To: Andrew Donnellan <ajd@...ux.ibm.com>
Cc: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Barrat <fbarrat@...ux.ibm.com>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in
 pnv_ioda_pick_m64_pe()

On Tue, Aug 12, 2025 at 11:07:08AM +1000, Andrew Donnellan wrote:
> On Mon, 2025-08-11 at 12:51 -0400, Yury Norov wrote:
> 
> > -	/* Allocate bitmap */
> > -	size = ALIGN(phb->ioda.total_pe_num / 8, sizeof(unsigned long));
> > -	pe_alloc = kzalloc(size, GFP_KERNEL);
> > +	pe_alloc = bitmap_alloc(phb->ioda.total_pe_num, GFP_KERNEL);
> 
> I haven't checked whether or not this has practical impact given what we later
> do with the bitmap - does this need to be bitmap_zalloc() to match the existing
> use of kzalloc()?

That's fair. I'll send v3 with bitmap_zalloc().