linux-kernel - Re: [PATCH] clk: qcom: gcc-qcs615: Fix gcc_sdcc2_apps_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e54l6omqbop5tlithm7cseldtbcz47sde6fo6wcoxvbordoa6w@l63sxertlypq>
Date: Mon, 11 Aug 2025 22:50:01 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Taniya Das <taniya.das@....qualcomm.com>
Cc: Richa Bharti <Richa.Bharti@...mens.com>, mturquette@...libre.com, 
	sboyd@...nel.org, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, srikanth.krishnakar@...mens.com, cedric.hombourger@...mens.com
Subject: Re: [PATCH] clk: qcom: gcc-qcs615: Fix gcc_sdcc2_apps_clk_src

On Tue, Jul 29, 2025 at 04:08:21PM +0530, Taniya Das wrote:
> 
> 
> On 7/29/2025 3:19 PM, Richa Bharti wrote:
> > On QCS615, we see the same issue as reported on SM8250 and SM6350:
> > "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot.
> > This is due to GPLL7 not being enabled by default as a parent clock.
> > 
> > Setting `.flags = CLK_OPS_PARENT_ENABLE` ensures that the parent (GPLL7)
> > gets prepared and enabled when switching to it, fixing the warning.
> > 
> > Fixes: 39d6dcf67fe9 ("clk: qcom: gcc: Add support for QCS615 GCC clocks")
> > Signed-off-by: Richa Bharti <Richa.Bharti@...mens.com>

Thank you Richa for your patch!

> > ---
> > This change is similar to upstream commits:
> > - SM8250: 783cb693828c ("clk: qcom: gcc-sm8250: Fix
> >   gcc_sdcc2_apps_clk_src")
> > - SM6350: df04d166d1f3 ("clk: qcom: gcc-sm6350: Fix
> >   gcc_sdcc2_apps_clk_src")
> > ---
> >  drivers/clk/qcom/gcc-qcs615.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/qcom/gcc-qcs615.c b/drivers/clk/qcom/gcc-qcs615.c
> > index 9695446bc2a3..b281f0dfe165 100644
> > --- a/drivers/clk/qcom/gcc-qcs615.c
> > +++ b/drivers/clk/qcom/gcc-qcs615.c
> > @@ -830,6 +830,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> >  		.name = "gcc_sdcc2_apps_clk_src",
> >  		.parent_data = gcc_parent_data_8,
> >  		.num_parents = ARRAY_SIZE(gcc_parent_data_8),
> > +		.flags = CLK_OPS_PARENT_ENABLE,
> 
> This is not the correct way to fix it just because SM8250 and SM6350
> uses this ops.
> 
> We are testing the right fix internally and will be posting.
> 

Please use such opportunities to educate us, rather than just tell us to
blindly wait for something (at least share your thoughts/hypothesis).

Regards,
Bjorn

> >  		.ops = &clk_rcg2_floor_ops,
> >  	},
> >  };
> 
> -- 
> Thanks,
> Taniya Das
>