linux-kernel - Re: [PATCH v2] net: tun: replace strcpy with strscpy for ifr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250811180546.1bd97b0c@kernel.org>
Date: Mon, 11 Aug 2025 18:05:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Miguel García <miguelgarciaroman8@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 willemdebruijn.kernel@...il.com, jasowang@...hat.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, skhan@...uxfoundation.org
Subject: Re: [PATCH v2] net: tun: replace strcpy with strscpy for ifr_name

On Mon, 11 Aug 2025 22:33:29 +0200 Miguel García wrote:
> Replace the strcpy() calls that copy the device name into ifr->ifr_name
> with strscpy() to avoid potential overflows and guarantee NULL termination.
> 
> Destination is ifr->ifr_name (size IFNAMSIZ).
> 
> Tested in QEMU (BusyBox rootfs):
>  - Created TUN devices via TUNSETIFF helper
>  - Set addresses and brought links up
>  - Verified long interface names are safely truncated (IFNAMSIZ-1)
> 
> v2:
> - Dropped third argument from strscpy(), inferred from field size.

Please don't post new patches in reply to old ones. Please read:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
there are multiple other problems with your submissions.
Please fix and repost.
-- 
pw-bot: cr