linux-kernel - Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508120615.TGJUom52-lkp@intel.com>
Date: Tue, 12 Aug 2025 08:00:09 +0800
From: kernel test robot <lkp@...el.com>
To: "Leo L. Schwab" <ewhac@...ac.org>, Hans de Goede <hansg@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Kate Hsuan <hpa@...hat.com>,
	"Leo L. Schwab" <ewhac@...ac.org>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.

Hi Leo,

kernel test robot noticed the following build errors:

[auto build test ERROR on hid/for-next]
[also build test ERROR on linus/master v6.17-rc1 next-20250808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leo-L-Schwab/HID-lg-g15-Add-support-for-Logitech-G13/20250811-070633
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20250810225617.1006272-2-ewhac%40ewhac.org
patch subject: [PATCH] HID: lg-g15 - Add support for Logitech G13.
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20250812/202508120615.TGJUom52-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250812/202508120615.TGJUom52-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508120615.TGJUom52-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/hid/hid-lg-g15.c: In function 'lg_g13_event':
>> drivers/hid/hid-lg-g15.c:703:68: error: 'struct led_classdev' has no member named 'brightness_hw_changed'
     703 |                 (!!TEST_BIT(rep->keybits, 23)) ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
         |                                                                    ^

vim +703 drivers/hid/hid-lg-g15.c

   665	
   666	static int lg_g13_event(struct lg_g15_data *g15, u8 const *data)
   667	{
   668		struct g13_input_report const * const rep = (struct g13_input_report *) data;
   669		int i, val;
   670		bool hw_brightness_changed;
   671	
   672		/*
   673		 * Main macropad and menu keys.
   674		 * Emit key events defined for each bit position.
   675		 */
   676		for (i = 0;  i < ARRAY_SIZE(g13_keys_for_bits);  ++i) {
   677			if (g13_keys_for_bits[i]) {
   678				val = TEST_BIT(rep->keybits, i);
   679				input_report_key(g15->input, g13_keys_for_bits[i], val);
   680			}
   681		}
   682		input_sync(g15->input);
   683	
   684		/*
   685		 * Joystick.
   686		 * Emit button and deflection events.
   687		 */
   688		for (i = 0;  i < ARRAY_SIZE(g13_keys_for_bits_js);  ++i) {
   689			if (g13_keys_for_bits_js[i]) {
   690				val = TEST_BIT(rep->keybits, i + 33);
   691				input_report_key(g15->input_js, g13_keys_for_bits_js[i], val);
   692			}
   693		}
   694		input_report_abs(g15->input_js, ABS_X, rep->joy_x);
   695		input_report_abs(g15->input_js, ABS_Y, rep->joy_y);
   696		input_sync(g15->input_js);
   697	
   698		/*
   699		 * Bit 23 of keybits[] reports the current backlight on/off state.  If
   700		 * it has changed from the last cached value, apply an update.
   701		 */
   702		hw_brightness_changed =
 > 703			(!!TEST_BIT(rep->keybits, 23)) ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
   704		if (hw_brightness_changed) {
   705			led_classdev_notify_brightness_hw_changed(
   706				&g15->leds[0].cdev,
   707				TEST_BIT(rep->keybits, 23) ? LED_FULL : LED_OFF);
   708		}
   709	
   710		return 0;
   711	}
   712	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki