linux-kernel - Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJrkdqrCG2FQZr53@ewhac.org>
Date: Mon, 11 Aug 2025 23:51:34 -0700
From: "Leo L. Schwab" <ewhac@...ac.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Hans de Goede <hansg@...nel.org>, Jiri Kosina <jikos@...nel.org>,
	Kate Hsuan <hpa@...hat.com>, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.

On Mon, Aug 11, 2025 at 07:00:24PM +0200, Markus Elfring wrote:
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
> 

On Mon, Aug 11, 2025 at 07:10:46PM +0200, Markus Elfring wrote:
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&g15->mutex);”?
> https://elixir.bootlin.com/linux/v6.16/source/include/linux/mutex.h#L225
> 

On Tue, Aug 12, 2025 at 08:00:09AM +0800, kernel test robot wrote:
> kernel test robot noticed the following build errors:
> [ ... ]
>    drivers/hid/hid-lg-g15.c: In function 'lg_g13_event':
> >> drivers/hid/hid-lg-g15.c:703:68: error: 'struct led_classdev' has no member named 'brightness_hw_changed'
>      703 |                 (!!TEST_BIT(rep->keybits, 23)) ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
>          |                                                                    ^
>
	Thank you.  Updated patch forthcoming which will hopefully address
these concerns.

					Schwab