linux-kernel - Re: [PATCH v3 0/6] media: ti, cdns: Multiple pixel support and misc fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <903bbeac-2717-44b0-888b-5a63937fb97c@ti.com>
Date: Tue, 12 Aug 2025 11:49:23 +0530
From: Rishikesh Donadkar <r-donadkar@...com>
To: Jai Luthra <jai.luthra@...asonboard.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Tomi Valkeinen
	<tomi.valkeinen@...asonboard.com>,
        Sakari Ailus
	<sakari.ailus@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>
CC: Devarsh Thakkar <devarsht@...com>, Vaishnav Achath <vaishnav.a@...com>,
        Changhuang Liang <changhuang.liang@...rfivetech.com>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>,
        Yemike Abhilash Chandra <y-abhilashchandra@...com>
Subject: Re: [PATCH v3 0/6] media: ti, cdns: Multiple pixel support and misc
 fixes


On 27/06/25 06:36, Jai Luthra wrote:
> Hi,

Hi Jai,

Thank you for the patches


>
> The first four patches in this series are miscellaneous fixes and
> improvements in the Cadence and TI CSI-RX drivers around probing, fwnode
> and link creation.
>
> The last two patches add support for transmitting multiple pixels per
> clock on the internal bus between Cadence CSI-RX bridge and TI CSI-RX
> wrapper. As this internal bus is 32-bit wide, the maximum number of
> pixels that can be transmitted per cycle depend upon the format's bit
> width. Secondly, the downstream element must support unpacking of
> multiple pixels.
>
> Thus we export a module function that can be used by the downstream
> driver to negotiate the pixels per cycle on the output pixel stream of
> the Cadence bridge.
>
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>


For the entire series,

Reviewed-by: Rishikesh Donadkar <r-donadkar@...com>

Tested-by: Rishikesh Donadkar <r-donadkar@...com>

Test Logs (AM62A + imx219): 
https://gist.github.com/Rishikesh-D/63f9b203a84087d1207ae7c98fa1fb40

> ---
> Changes in v3:
> - Move cdns-csi2rx header to include/media
> - Export symbol from cdns-csi2rx.c to be used only through
>    the j721e-csi2rx.c module namespace
> - Other minor fixes suggested by Sakari
> - Add Abhilash's T-by tags
> - Link to v2: https://lore.kernel.org/r/20250410-probe_fixes-v2-0-801bc6eebdea@ideasonboard.com
>
> Changes in v2:
> - Rebase on v6.15-rc1
> - Fix lkp warnings in PATCH 5/6 missing header for FIELD_PREP
> - Add R-By tags from Devarsh and Changhuang
> - Link to v1: https://lore.kernel.org/r/20250324-probe_fixes-v1-0-5cd5b9e1cfac@ideasonboard.com
>
> ---
> Jai Luthra (6):
>        media: ti: j721e-csi2rx: Use devm_of_platform_populate
>        media: ti: j721e-csi2rx: Use fwnode_get_named_child_node
>        media: ti: j721e-csi2rx: Fix source subdev link creation
>        media: cadence: csi2rx: Implement get_fwnode_pad op
>        media: cadence: cdns-csi2rx: Support multiple pixels per clock cycle
>        media: ti: j721e-csi2rx: Support multiple pixels per clock
>
>   MAINTAINERS                                        |  1 +
>   drivers/media/platform/cadence/cdns-csi2rx.c       | 74 ++++++++++++++++------
>   drivers/media/platform/ti/Kconfig                  |  3 +-
>   .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c  | 65 ++++++++++++++-----
>   include/media/cadence/cdns-csi2rx.h                | 19 ++++++
>   5 files changed, 127 insertions(+), 35 deletions(-)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250314-probe_fixes-7e0ec33c7fee
>
> Best regards,