linux-kernel - Re: [PATCH 2/3] RDS: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <112c31733efe7db786a37cad9113c7292b7c1bdd.camel@oracle.com>
Date: Tue, 12 Aug 2025 06:54:56 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "rongqianfeng@...o.com" <rongqianfeng@...o.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "horms@...nel.org"
	<horms@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH 2/3] RDS: remove redundant __GFP_NOWARN

On Sun, 2025-08-10 at 15:29 +0800, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
Looks pretty straight forward to me.  Thanks Qianfeng.

Reviewed-by: Allison Henderson <allison.henderson@...cle.com>
> ---
>  net/rds/ib_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index e53b7f266bd7..4248dfa816eb 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -1034,7 +1034,7 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
>  		rds_ib_stats_inc(s_ib_rx_ring_empty);
>  
>  	if (rds_ib_ring_low(&ic->i_recv_ring)) {
> -		rds_ib_recv_refill(conn, 0, GFP_NOWAIT | __GFP_NOWARN);
> +		rds_ib_recv_refill(conn, 0, GFP_NOWAIT);
>  		rds_ib_stats_inc(s_ib_rx_refill_from_cq);
>  	}
>  }