linux-kernel - [PATCH] pwm: Rename GPIO set_rv callback back to its original name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5366fcd01c9f8b374914e6137f01d156033c8a9e.1754986373.git.geert+renesas@glider.be>
Date: Tue, 12 Aug 2025 10:14:59 +0200
From: Geert Uytterhoeven <geert+renesas@...der.be>
To: Uwe Kleine-König <ukleinek@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc: linux-pwm@...r.kernel.org,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: [PATCH] pwm: Rename GPIO set_rv callback back to its original name

As of commit d9d87d90cc0b10cd ("treewide: rename GPIO set callbacks back
to their original names"), the .set_rv() callback no longer exists:

    drivers/pwm/core.c: In function ‘__pwmchip_add’:
    drivers/pwm/core.c:2514:26: error: ‘struct gpio_chip’ has no member named ‘set_rv’
     2514 |                         .set_rv = pwm_gpio_set,
	  |                          ^~~~~~
    drivers/pwm/core.c:2514:35: error: initialization of ‘int (*)(struct gpio_chip *, unsigned int)’ from incompatible pointer type ‘int (*)(struct gpio_chip *, unsigned int,  int)’ [-Werror=incompatible-pointer-types]
     2514 |                         .set_rv = pwm_gpio_set,
	  |                                   ^~~~~~~~~~~~
    drivers/pwm/core.c:2514:35: note: (near initialization for ‘(anonymous).direction_input’)

Fixes: 1c84bb7fc0ad5841 ("pwm: Provide a gpio device for waveform drivers")
Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
---
Probably to be folded into the original commit, when pwm/for-next is
rebased to v6.17-rc1.
---
 drivers/pwm/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index b05186b9569eba29..ec4112e6209a4c77 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -2511,7 +2511,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner)
 			.request = pwm_gpio_request,
 			.free = pwm_gpio_free,
 			.get_direction = pwm_gpio_get_direction,
-			.set_rv = pwm_gpio_set,
+			.set = pwm_gpio_set,
 			.base = -1,
 			.ngpio = chip->npwm,
 			.can_sleep = true,
-- 
2.43.0